Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aet rootzone name fix #132

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Aet rootzone name fix #132

merged 4 commits into from
Sep 6, 2024

Conversation

madMatchstick
Copy link
Contributor

VERY minor updates left over from PR #105. is_aet_rootzone (boolean flag) name changed for consistency but was ever fully adopted in bmi spec & configs.

Changes

  • aet_rootzone now reads is_aet_rootzone

Testing

  1. All workflows pass

@ajkhattak
Copy link
Contributor

@madMatchstick good catch, looks good to me. The test https://github.com/NOAA-OWP/cfe/actions/runs/10742427474/job/29795025454?pr=132 is failing and I think it should be okay once we merge it, correct?

@SnowHydrology
Copy link
Contributor

SnowHydrology commented Sep 6, 2024 •
edited
Loading

@ajkhattak, @madMatchstick and I are a bit stumped on that issue at the moment. There might be an issue with using GitHub secrets in an action when initiated by a fork.

@madMatchstick madMatchstick changed the base branch from master to dev September 6, 2024 17:45
@madMatchstick madMatchstick removed the request for review from ajkhattak September 6, 2024 17:45
@madMatchstick madMatchstick merged commit 7d2f654 into NOAA-OWP:dev Sep 6, 2024
4 of 5 checks passed
@madMatchstick
Copy link
Contributor Author

madMatchstick commented Sep 6, 2024 •
edited
Loading

@ajkhattak, @madMatchstick and I are a bit stumped on that issue at the moment. There might be an issue with using GitHub secrets in an action when initiated by a fork.

@SnowHydrology is correct about the forked PRs. I submitted this one to dev as a test.

@ajkhattak You can disregard this PR (as I already merged :)) but see the more official PR from dev to master here, #133. Note that the add-to-project test passes. Thanks!

ajkhattak pushed a commit that referenced this pull request Sep 10, 2024
@madMatchstick @ajkhattak
Aet rootzone name fix (#132)
c462707 
* Update bmi_cfe.c

* Update cfe_config_laramie_pass_aet_rz.txt

* Update cfe_config_laramie_pass_aet_rz.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madMatchstick @ajkhattak @SnowHydrology